marco/i3status
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

strncpy + strlen is pointless (#312)

Browse Source 
strlen already assumes that the string is NULL-terminated.

Fixes -Wstringop-overflow warning
This commit is contained in:
Orestis 2018-10-07 21:26:24 +03:00 committed by Michael Stapelberg
parent 5c9d12befa
commit 494efd49a2
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
i3status.c
View File

@ -227,9 +227,10 @@ static char *resolve_tilde(const char *path) {
} else { } else {
head = globbuf.gl_pathv[0]; head = globbuf.gl_pathv[0];
result = scalloc(strlen(head) + (tail ? strlen(tail) : 0) + 1); result = scalloc(strlen(head) + (tail ? strlen(tail) : 0) + 1);
strncpy(result, head, strlen(head)); strcpy(result, head);
if (tail) if (tail) {
strncat(result, tail, strlen(tail)); strcat(result, tail);
}
} }
globfree(&globbuf); globfree(&globbuf);