Commit Graph

395 Commits

Author SHA1 Message Date
Jonas Große Sundrup
afc73e1982
Initialize fields with zero bytes in wireless module
Previously, the fields in the wireless module were declared but not explicitly
initialized upon declaration. As nothing else would do so afterwards, this
could introduce random characters left over in the memory segment into
the fields. This was explicitly observed in the essid-field, but likely
a possibility for other fields as well. Hence, this commit adds explicit
initialization with zero bytes to all fields to ensure proper
termination of all fields.

Fixes #432
2020-10-09 12:36:41 +02:00
Jonas Große Sundrup
3451a0d9fc
Allow selective pango-markup in tztime-module (#430)
Closes #421
2020-08-31 08:30:59 +02:00
Michael Nolan
e19539e5f6
Add support for batteries outputting Time to empty on linux (#378)
* Add support for batteries outputting Time to empty on linux

The battery in the pinebook pro does not output the remaining charge
in Wh or mAh, so i3 cannot calculate the time remaining. However, it
does directly output the number of minutes remaining on in
POWER_SUPPLY_TIME_TO_EMPTY. This adds support for reading this field
and converting it to seconds_remaining.

* Add testcase for POWER_SUPPLY_TIME_TO_EMTY_NOW
2020-06-15 09:09:06 +02:00
Mikel Ward
09358d2698
Use the PulseAudio port name rather than the sink name (#419)
This generates much friendlier names on all my systems, e.g.
"HDMI / DisplayPort 5" rather than
"Ellesmere HDMI Audio [Radeon RX 470/480 / 570/580/590] Digital Stereo (HDMI 5)"
2020-06-15 09:07:27 +02:00
Orestis Floros
24c417966e
Fix fall-through warnings 2020-05-01 19:09:35 +02:00
Orestis Floros
980164ccca
Fix various memory leaks
Fixes #362
2020-05-01 13:55:19 +02:00
Ingo Bürk
ef03d7c479
Merge pull request #415 from orestisfl/resolve-tilde
Resolve tilde
2020-05-01 13:17:09 +02:00
Orestis Floros
94d10968c9
print_file_contents: Resolve tilde
Fixes #350
2020-05-01 12:20:34 +02:00
Orestis Floros
d8e8eb2eef
Move general functions scalloc, sstrdup out of i3status.c 2020-05-01 12:16:55 +02:00
Orestis Floros
84ad5c93db
travis: update dist, add custom matrix
New matrix for 5 jobs in total.

Updates our checks to bionic & xenial. Trusty could also be
included but it is a bit outdated at this point.

I use bionic to pull a more recent clang-format and use a dedicated job
just to check formatting. An alternative would be to conditionally run
the formatting script only on bionic.

I don't think that there is a better way to expand a `dist` x `compiler`
matrix (except using docker).
2020-05-01 11:19:41 +02:00
Ingo Bürk
675c423647
Merge pull request #409 from Stunkymonkey/format_placeholder-volume
Format placeholder volume
2020-05-01 09:42:49 +02:00
Orestis Floros
a68524ee4a
Fix various warnings
- unused variable ‘walk’ [-Wunused-variable]
- implicit declaration of built-in function ‘free’
[-Wimplicit-function-declaration]
- initialization discards ‘const’ qualifier from pointer target type
[-Wdiscarded-qualifiers]
- variable 'ram_used' is used uninitialized whenever 'if' condition is
false [-Wsometimes-uninitialized]. This is actually easily reproducible
by specifying `memory_used_method = "XXX"`.
- comparison of integers of different signs: 'int' and 'unsigned long'
[-Wsign-compare] (for `exponent`)
2020-05-01 01:06:38 +02:00
Felix Buehler
269c06c4bb [volume] fix memory leak
mend
2020-04-26 23:00:41 +02:00
Aleksandr Matveev
7191cce8e9 wireless: Fix rendering bitrate 2020-04-11 23:05:35 +03:00
Aleksandr Matveev
18eb04d02d wireless: support connection bitrate on FreeBSD 2020-04-11 22:29:03 +03:00
tripledonkey
d088baea4f
use statvfs f_frsize for file system block size (#405)
* use statvfs f_frsize for file system block size
2020-04-08 16:06:35 +02:00
Ingo Bürk
582432fcc6
Merge pull request #402 from Stunkymonkey/format_placeholder-wireless_info
use format_placeholder for wireless_info
2020-04-08 08:41:14 +02:00
Felix Buehler
44fad4d2cd use format_placeholder for volume 2020-04-07 23:02:30 +02:00
Ingo Bürk
e697a1f19f
Merge pull request #404 from Stunkymonkey/format_placeholder-file_content
use format_placeholder for file_content
2020-04-07 08:31:57 +02:00
Felix Buehler
f0b5758c72 use format_placeholder for file_content 2020-04-03 16:15:38 +02:00
Felix Buehler
fc95763f7b remove goto-labels from wireless_info 2020-04-03 16:01:55 +02:00
Ingo Bürk
1858cd8dfb
Merge pull request #401 from Stunkymonkey/format_placeholder-time
use format_placeholder for time
2020-04-03 08:38:30 +02:00
Ingo Bürk
4980193dc7
Merge pull request #400 from Stunkymonkey/format_placeholder-run_watch
use format_placeholder for run_watch
2020-04-03 08:38:04 +02:00
Ingo Bürk
ffa429d145
Merge pull request #399 from Stunkymonkey/format_placeholder-path_exists
use format_placeholder for path_exists
2020-04-03 08:37:05 +02:00
Felix Buehler
ae2566f28e use format_placeholder for wireless_info 2020-03-31 17:05:48 +02:00
Felix Buehler
7418b5bebb use format_placeholder for time 2020-03-31 16:13:24 +02:00
Felix Buehler
dd683f618a use format_placeholder for run_watch 2020-03-31 16:08:07 +02:00
Felix Buehler
84c0eddd66 use format_placeholder for path_exists 2020-03-31 16:01:17 +02:00
Ingo Bürk
b4c1bb97af
Merge pull request #398 from Stunkymonkey/format_placeholder-mem
use format_placeholder for mem
2020-03-31 15:31:34 +02:00
Felix Buehler
066e813331 use format_placeholder for mem 2020-03-31 15:21:46 +02:00
Ingo Bürk
b4555f53e2
Merge pull request #396 from Stunkymonkey/format_placeholder-ipv6_addr
use format_placeholder for ipv6_addr
2020-03-31 15:06:51 +02:00
Felix Buehler
ebaeb8fb23 use format_placeholder for ipv6_addr 2020-03-31 15:03:18 +02:00
Felix Buehler
7aa3031cb6 use format_placeholder for load 2020-03-31 14:56:21 +02:00
Samuel Holland
585d0700c7 avoid out-of-bounds read after invalid %cpu conversion
In the case where no CPU number is given, skipping a character of
padding actually skips the null terminator, causing further iterations
through the loop to read out of bounds. Have sscanf() return the number
of characters read, instead of reconstructing it from the CPU number.

This was observed as a failure in test 024-cpu-usage-invalid-cpu.
2020-03-28 21:02:02 -05:00
nia
9b8403ac84 print_volume: Native NetBSD audio support
Avoid using the OSS emulation layer to fetch the master volume,
and instead share the audioio code with OpenBSD.

Avoid a failed read on the master control's mute enum if it can't
be found, because sometimes there isn't one.
2020-03-11 23:29:56 +00:00
Ingo Bürk
6eb70f10d2
Merge pull request #390 from Stunkymonkey/format_placeholder-eth
use format_placeholder for eth.info
2020-03-06 13:52:11 +01:00
Felix Buehler
e60eb9f3d1 use format_placeholder for disk.info 2020-03-03 21:32:49 +01:00
Felix Buehler
48119d890a use format_placeholder for eth.info 2020-03-03 21:31:56 +01:00
Ingo Bürk
ae67594b6d
Merge pull request #386 from Stunkymonkey/format_placeholder-date
use format_placeholder for ddate
2020-02-21 17:35:20 +01:00
Felix Buehler
0a5f0ef115 use exact size for known strings 2020-02-21 15:23:37 +01:00
Felix Buehler
3ceb0b8fcf use format_placeholder for ddate 2020-02-18 20:22:36 +01:00
Felix Buehler
2ef1d7440a use format_placeholder for cpu_temperature 2020-02-18 17:51:12 +01:00
Ingo Bürk
b61e959a58
Merge pull request #381 from Stunkymonkey/format_wireless
add wireless format-options
2020-02-17 08:34:09 +01:00
Felix Buehler
42e7147291 add wireless format-options 2020-02-10 22:33:20 +01:00
Felix Buehler
b5a804d1af use format_placeholder for battery 2020-02-10 21:05:18 +01:00
zsugabubus
ad29f204b7
print_mem: Fix overflow on 32-bit systems
Values stored as `unsigned long` in "/proc/meminfo" but they were
handled as `long`.

On 32-bit systems with 4G memory it results in integer overflow.
2019-11-24 23:41:46 +01:00
grmat
abfe05c8bd Introduce format_percentage for battery (#371)
Allow custom output, backwards-compatible to integer_battery_capacity
2019-11-16 16:26:26 +01:00
MK13
572c96d63e Introduce memory options 'unit' and 'decimals'
Previously the format placeholders were auto-converted to the maximum possible
unit, e.g. /proc/meminfo reports MemTotal of 16307104kB which will get
converted to 15.6GiB. It is now possible to specifiy the target unit, e.g. Mi,
which will be used for the conversion - in the example it would lead to
15924.9MiB.

The resulting number can now be further formatted via the decimal option. It
allows to specify the number of decimals to use, e.g. 15.6GiB vs. 15GiB or
15924.9MiB vs. 15925MiB.
2019-10-26 15:32:32 +02:00
Sascha Wessel
3d6b1b576b wireless: update %signal and %quality based on station info on Linux (#368)
Use station info instead of bss info to update %signal and %quality.
Bss info is based on scan info and doesn't get updated often. Station
info get's updated with every beacon. Bss info still used as fallback.
2019-10-21 08:48:50 +02:00
Olivier Gayot
49cf3d7edb Mention the return value of the slurp function and the implications
Signed-off-by: Olivier Gayot <olivier.gayot@sigexec.com>
2019-09-19 15:48:59 +02:00