Commit Graph

13 Commits

Author SHA1 Message Date
Felix Buehler
50b899ba42 hide seconds in battery by default 2018-06-29 14:37:48 +02:00
johcgt
d5c69a9d60 Treat zero battery capacity as "not available" (#259)
`print_battery_info` computes `batt_info.percentage_remaining` by
dividing batt_info.remaining by `full`. If `full` is `0` then the
battery remaining will be reported as "inf".

Before this, it tries to set `full` to either the design capacity or to
the last known good charge. It determines if these values are available
by checking whether their fields in `batt_info` are non-negative. As it
initialized `batt_info` with values of `-1`, a non-negative value
implies that something has provided a value.

`slurp_all_batteries` and `add_battery_info` however initialize these
fields to zero, so if these functions are called then
`batt_info.full_design` will always be used.

This means that on systems that don't provide a value for design
capacity the percentage remaining will be reported as "inf", unless the
user has set `last_full_capacity` to `true` in their `i3status.conf`.

This patch changes `print_battery_info` to expect values for the battery
capacity to be strictly greater than zero. This seems reasonable as a
battery with a capacity of zero isn't useful.

An alternative solution would be to change `slurp_all_batteries` and
`add_battery_info` to initialize `batt_info` with `-1`, as
`print_battery_info` does. This is less appealing as `add_battery_info`
is accumulating the values, so using `-1` would introduce off-by-one
errors without additional code to avoid them.
2018-01-28 15:37:51 +01:00
Emeric Planet
6464ae2df9 Add network test cases (#246) 2017-11-20 19:51:48 +01:00
Emeric Planet
884e4da673 Fix CPU unit tests (#239)
Support any amount of available cores on testing machine.
2017-08-29 19:01:30 +02:00
Emeric Planet
c7dea74751 Add battery capacity parsing (#216)
The Linux power supply class defines three entries to provide battery status.
One of them wasn't used: POWER_SUPPLY_CAPACITY.

https://www.kernel.org/doc/Documentation/power/power_supply_class.txt
2017-04-13 21:46:21 +02:00
eplanet
94651257ce Multiple CPU support for cpu_usage (#209)
This change addresses the issue #199 asking for multiple CPU support. It
takes an arbitrary CPU number and outputs its usage using the same
arithmetics as for CPU aggregation. It currently doesn't support
FreeBSD.
2017-03-26 06:54:07 -04:00
eplanet
6f7724ec64 Adding documentation for PR #179 (#182) 2016-11-19 06:02:10 -08:00
Michael Stapelberg
b91e2a4b71 Merge pull request #179 from mihaicmn/feature-threshold-format
Provide format_above_threshold/format_below_threshold options
2016-11-16 13:45:59 -08:00
Mihai Coman
562f6e383d Add unit tests for threshold format 2016-11-15 13:34:06 +02:00
eplanet
9c47240523 Added test case for run_watch
The valid test case assumes pid 1 exists, which should always
be true on Unix environment.
2016-11-14 21:33:09 +00:00
eplanet
243d08e1ad Added unit test case for path_exists 2016-11-14 21:24:16 +00:00
eplanet
7c9108c9b9 Added unit test case for CPU temperature 2016-11-14 20:58:58 +00:00
eplanet
b0af4e4c85 Unit testing in Travis (#170) 2016-11-14 00:13:44 -08:00