marco/qmk
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid exceptions when layouts contain OOB matrix values (#22609)

Browse Source
This commit is contained in:
Joel Challis 2023-12-05 13:32:07 +00:00 committed by GitHub
parent 229633395b
commit bba5c14933
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/python/qmk/cli/generate/keyboard_c.py
View File

@ -64,12 +64,15 @@ def _gen_matrix_mask(info_data):
rows = info_data['matrix_size']['rows'] rows = info_data['matrix_size']['rows']
# Default mask to everything disabled # Default mask to everything disabled
mask = [['0'] * cols for i in range(rows)] mask = [['0'] * cols for _ in range(rows)]
# Mirror layout macros squashed on top of each other # Mirror layout macros squashed on top of each other
for layout_data in info_data['layouts'].values(): for layout_name, layout_data in info_data['layouts'].items():
for key_data in layout_data['layout']: for key_data in layout_data['layout']:
row, col = key_data['matrix'] row, col = key_data['matrix']
if row >= rows or col >= cols:
cli.log.error(f'Skipping matrix_mask due to {layout_name} containing invalid matrix values')
return []
mask[row][col] = '1' mask[row][col] = '1'
lines = [] lines = []