marco/calorimeter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 4 Wiki Activity

Fix json misalignment and error representation #8

Merged
marco merged 2 commits from fix-json-misalignment-and-error-representation into master 2024-12-22 17:29:21 +00:00
Conversation 0 Commits 2 Files Changed 7 +149 -79
marco commented 2024-12-22 17:23:56 +00:00
Owner
Copy Link
  1. Fix a bug that caused an exception when the kcal per 100g was not given. Now, we fall back to zero or take the 'kcal per 100g prepared' field.
  2. Handle exception when camera permission is not granted:
    Moved the call to BarcodeScanner.scan() to the BLoC. Simplified the event and changed name.
  3. FoodEntry-Bloc does not set the error strings directly. Localisations are dependent on BuildContext and so I had to detach the error generation from error display.
1. Fix a bug that caused an exception when the kcal per 100g was not given. Now, we fall back to zero or take the 'kcal per 100g prepared' field. 2. Handle exception when camera permission is not granted: Moved the call to BarcodeScanner.scan() to the BLoC. Simplified the event and changed name. 3. FoodEntry-Bloc does not set the error strings directly. Localisations are dependent on BuildContext and so I had to detach the error generation from error display.
marco added 2 commits 2024-12-22 17:23:57 +00:00
marco changed title from fix-json-misalignment-and-error-representation to Fix json misalignment and error representation 2024-12-22 17:24:15 +00:00
marco merged commit 63e9b471b4 into master 2024-12-22 17:29:21 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: marco/calorimeter#8
No description provided.
Delete Branch "fix-json-misalignment-and-error-representation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?